fixed adjust roi test

- Added tests for adding, removing, renaming, and adjusting ROIs.
- Implemented tests for changing ROI color and toggling normalization.
- Added tests for exporting data to CSV and RITS formats.
- Included utility method to open the Spectrum Viewer.

Author: ashmeigh

mantidimaging/gui/test/gui_system_spectrum_test.py

@@ -3,11 +3,14 @@
 from __future__ import annotations
 
 from unittest import mock
+from pathlib import Path
 
 from PyQt5.QtCore import Qt
 from PyQt5.QtTest import QTest
 
+from mantidimaging.core.utility.sensible_roi import SensibleROI
 from mantidimaging.gui.test.gui_system_base import GuiSystemBase, SHOW_DELAY, SHORT_DELAY
+from mantidimaging.gui.windows.spectrum_viewer.model import SpecType
 from mantidimaging.test_helpers.qt_test_helpers import wait_until
 
 
@@ -57,6 +60,19 @@ def test_add_roi(self) -> None:
             self.assertIn(f'roi_{i}', self.spectrum_window.roi_table_model.roi_names())
             self.assertIn(f'roi_{i}', self.spectrum_window.spectrum_widget.roi_dict)
 
+    def test_remove_roi(self) -> None:
+        QTest.mouseClick(self.spectrum_window.addBtn, Qt.MouseButton.LeftButton)
+        QTest.qWait(SHORT_DELAY)
+        initial_roi_count = self.spectrum_window.roi_table_model.rowCount()
+
+        QTest.mouseClick(self.spectrum_window.removeBtn, Qt.MouseButton.LeftButton)
+        QTest.qWait(SHORT_DELAY)
+        final_roi_count = self.spectrum_window.roi_table_model.rowCount()
+
+        self.assertEqual(final_roi_count, initial_roi_count - 1)
+        self.assertNotIn(f'roi_{initial_roi_count - 1}', self.spectrum_window.roi_table_model.roi_names())
+        self.assertNotIn(f'roi_{initial_roi_count - 1}', self.spectrum_window.spectrum_widget.roi_dict)
+
     def test_change_roi_color(self) -> None:
         QTest.mouseClick(self.spectrum_window.addBtn, Qt.MouseButton.LeftButton)
         QTest.qWait(SHORT_DELAY)
@@ -80,22 +96,19 @@ def test_rename_roi(self) -> None:
     def test_adjust_roi(self):
         QTest.mouseClick(self.spectrum_window.addBtn, Qt.MouseButton.LeftButton)
         QTest.qWait(SHORT_DELAY)
-        roi_name = self.spectrum_window.presenter.get_roi_names()[0]
-        roi = self.spectrum_window.presenter.model.get_roi(roi_name)
-        new_roi = roi.copy()
-        new_roi.left += 10
-        new_roi.top += 10
-        self.spectrum_window.presenter.model.set_roi(roi_name, new_roi)
+
+        roi_names = self.spectrum_window.presenter.get_roi_names()
+        roi_name = next(name for name in roi_names if name != 'all')
+
+        roi_widget = self.spectrum_window.spectrum_widget.roi_dict[roi_name]
+
+        roi_widget.setPos((roi_widget.pos().x() + 10, roi_widget.pos().y() + 10))
         self.spectrum_window.presenter.handle_roi_moved()
-        updated_roi = self.spectrum_window.presenter.model.get_roi(roi_name)
-        assert updated_roi.left == new_roi.left
-        assert updated_roi.top == new_roi.top
 
-    def test_reset_units_menu(self) -> None:
-        self.assertFalse(self.spectrum_window.tof_mode_select_group.isEnabled())
+        updated_roi = self.spectrum_window.presenter.model.get_roi(roi_name)
 
-        self.spectrum_window.presenter.handle_sample_change("sample_uuid")
-        self.assertTrue(self.spectrum_window.tof_mode_select_group.isEnabled())
+        assert updated_roi.left == roi_widget.pos().x()
+        assert updated_roi.top == roi_widget.pos().y()
 
     def test_normalisation_toggle(self):
         self.spectrum_window.normaliseCheckBox.setCheckState(Qt.CheckState.Checked)
@@ -114,3 +127,18 @@ def test_export_csv(self) -> None:
             with open("test_output.csv", "r") as file:
                 lines = file.readlines()
                 self.assertGreater(len(lines), 1)
+
+    @mock.patch("mantidimaging.gui.windows.spectrum_viewer.presenter.SpectrumViewerWindowPresenter._async_save_done")
+    def test_export_rits(self, mock_async_save_done):
+        with mock.patch(
+                'mantidimaging.gui.windows.spectrum_viewer.view.SpectrumViewerWindowView.get_rits_export_filename'
+        ) as mock_get_rits_export_filename:
+            mock_get_rits_export_filename.return_value = '/tmp/test_export.dat'
+            QTest.mouseClick(self.spectrum_window.exportButtonRITS, Qt.MouseButton.LeftButton)
+            QTest.qWait(SHORT_DELAY)
+            wait_until(lambda: mock_async_save_done.call_count > 0)
+
+    def test_reset_units_menu(self) -> None:
+        self.assertFalse(self.spectrum_window.tof_mode_select_group.isEnabled())
+        self.spectrum_window.presenter.handle_sample_change("uuid")
+        self.assertTrue(self.spectrum_window.tof_mode_select_group.isEnabled())