Remove unused is_dataset_strict methods

Author: samtygier-stfc

mantidimaging/gui/windows/main/model.py

@@ -256,15 +256,3 @@ def recon_list_ids(self) -> list[uuid.UUID]:
 
     def get_recon_list_id(self, parent_id: uuid.UUID) -> uuid.UUID:
         return self.datasets[parent_id].recons.id
-
-    def is_dataset_strict(self, ds_id: uuid.UUID) -> bool:
-        """
-        :param ds_id: The dataset ID
-        :return: True if the dataset is Strict, False otherwise
-        """
-        for ds in self.datasets.values():
-            if ds.id == ds_id:
-                if isinstance(ds, StrictDataset):
-                    return True
-                return False
-        raise RuntimeError(f"Unable to find dataset with ID {ds_id}")

mantidimaging/gui/windows/main/presenter.py

@@ -843,9 +843,6 @@ def _create_strict_dataset_stack_name(stack_type: str, dataset_name: str) -> str
         """
         return f"{stack_type} {dataset_name}"
 
-    def is_dataset_strict(self, ds_id: uuid.UUID) -> bool:
-        return self.model.is_dataset_strict(ds_id)
-
     def do_update_UI(self) -> None:
         if settings.value('use_os_defaults', defaultValue='True') == 'True':
             extra_style = settings.value('extra_style_default')

mantidimaging/gui/windows/main/test/model_test.py

@@ -538,17 +538,3 @@ def test_do_nexus_save_success(self, nexus_save):
 
         self.model.do_nexus_saving(sd.id, path, sample_name, save_as_float)
         nexus_save.assert_called_once_with(sd, path, sample_name, save_as_float)
-
-    def test_is_dataset_strict_returns_true(self):
-        strict_ds = StrictDataset(sample=generate_images())
-        self.model.add_dataset_to_model(strict_ds)
-        self.assertTrue(self.model.is_dataset_strict(strict_ds.id))
-
-    def test_is_dataset_strict_returns_false(self):
-        mixed_ds = MixedDataset(stacks=[generate_images()])
-        self.model.add_dataset_to_model(mixed_ds)
-        self.assertFalse(self.model.is_dataset_strict(mixed_ds.id))
-
-    def test_is_dataset_strict_raises(self):
-        with self.assertRaises(RuntimeError):
-            self.model.is_dataset_strict(uuid.uuid4())

mantidimaging/gui/windows/main/test/presenter_test.py

@@ -1060,11 +1060,6 @@ def test_move_stack_to_strict_dataset(self):
         self.assertNotIn(stack_to_move, origin_dataset)
         assert stack_to_move.name == new_stack_name
 
-    def test_is_dataset_strict(self):
-        ds_id = "ds-id"
-        self.presenter.is_dataset_strict(ds_id)
-        self.model.is_dataset_strict.assert_called_once_with(ds_id)
-
 
 if __name__ == '__main__':
     unittest.main()

mantidimaging/gui/windows/main/test/view_test.py

@@ -515,11 +515,6 @@ def test_show_move_stack_dialog(self):
                                                     stack_data_type)
             move_stack_mock.return_value.show.assert_called_once()
 
-    def test_is_dataset_strict(self):
-        ds_id = "ds-id"
-        self.view.is_dataset_strict(ds_id)
-        self.presenter.is_dataset_strict.assert_called_once_with(ds_id)
-
     @mock.patch("PyQt5.QtWidgets.QFileDialog.getExistingDirectory")
     @mock.patch("mantidimaging.gui.windows.main.MainWindowView.show_live_viewer")
     def test_live_viewer_asks_for_data_dir(self, mock_show_live_viewer, mock_get_existing_dir):

mantidimaging/gui/windows/main/view.py

@@ -776,6 +776,3 @@ def show_move_stack_dialog(self, origin_dataset_id: uuid.UUID, stack_id: uuid.UU
         self.move_stack_dialog = MoveStackDialog(self, origin_dataset_id, stack_id, origin_dataset_name,
                                                  stack_data_type)
         self.move_stack_dialog.show()
-
-    def is_dataset_strict(self, ds_id: UUID) -> bool:
-        return self.presenter.is_dataset_strict(ds_id)