Skip to content

Conversation

JackEAllen
Copy link
Collaborator

@JackEAllen JackEAllen commented Jul 11, 2024

Issue

Closes #2273

Description

Add a description of the changes made.
Modify Live Viewer window current image label to display the modified file timestamp to improved distinguishability between two scans which overwrite the same file, but look similar.

Testing

Describe the tests that were used to verify your changes.

  • Manually tested using simulate live viewer utility script.

Acceptance Criteria

How should the reviewer test your changes?

  • The Live Viewer displays the current image filename and corresponding timestamp

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

docs/release_notes/next/feature-2273-live-view-img-timestamp

@JackEAllen JackEAllen force-pushed the 2273_liveview_img_timestamp branch from a669a76 to 33b46d2 Compare July 11, 2024 12:28
@JackEAllen
Copy link
Collaborator Author

This PR requires new GUI baselines as there is a change to the UI of the Live Viewer window.

@JackEAllen JackEAllen changed the title 2273 liveview img timestamp Live Viewer Image Timestamp Jul 15, 2024
@coveralls
Copy link

coveralls commented Jul 15, 2024

Coverage Status

coverage: 74.313% (-0.003%) from 74.316%
when pulling c10991f on 2273_liveview_img_timestamp
into 79a43a1 on main.

@JackEAllen JackEAllen force-pushed the 2273_liveview_img_timestamp branch 10 times, most recently from e52937b to 5b0f4b5 Compare July 17, 2024 09:08
@JackEAllen JackEAllen self-assigned this Aug 2, 2024
@JackEAllen JackEAllen force-pushed the 2273_liveview_img_timestamp branch 3 times, most recently from f639c46 to 67c8c89 Compare August 6, 2024 10:16
@JackEAllen JackEAllen marked this pull request as ready for review August 6, 2024 11:08
@JackEAllen JackEAllen force-pushed the 2273_liveview_img_timestamp branch from 00604e2 to e1ed2b2 Compare August 7, 2024 14:04
@JackEAllen JackEAllen force-pushed the 2273_liveview_img_timestamp branch 2 times, most recently from 15319d8 to 234f270 Compare August 8, 2024 15:55
@JackEAllen JackEAllen force-pushed the 2273_liveview_img_timestamp branch from 234f270 to c10991f Compare August 8, 2024 15:56
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shows time for simulated live data correctly.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 52ac46e Aug 8, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2273_liveview_img_timestamp branch August 8, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live Viewer: Display File Timestamp
3 participants