Fix Monitor Normalization Error for 180-Degree Stack #2287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
Jul 25, 2024
Comment on lines
281
to
284
| if not self.model.selected_filter.log_180_degree: | ||
| if task.progress: | ||
| task.progress("Skipping normalization for the 180-degree stack.") | ||
| continue |
There was a problem hiding this comment.
This should move inside the other if statement.
if use_new_data and not self.applying_to_all and not self.is_a_proj180deg(stack):
if not self.model.selected_filter.allow_for_180_projection:
samtygier-stfc
requested changes
Aug 8, 2024
Comment on lines
279
to
286
| if use_new_data and not self.applying_to_all: | ||
| if self.is_a_proj180deg(stack): | ||
| if self.model.selected_filter.allow_for_180_projection: | ||
| self._do_apply_filter_sync([stack.proj180deg]) | ||
| else: | ||
| if task.progress: | ||
| task.progress("Skipping normalization for the 180-degree stack.") | ||
| continue |
There was a problem hiding this comment.
This just needs the if self.model.selected_filter.allow_for_180_projection: check added. The self.is_a_proj180deg(stack): is breaking the tests (makes this never run). Also the task.progress message is not needed.
samtygier-stfc
previously approved these changes
Aug 14, 2024
samtygier-stfc
force-pushed
the
log_error_mon_handle
branch
from
99ae981 to
2fc72ec
Compare
samtygier-stfc
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix Monitor Normalization Error for 180-Degree Stack (#2222)
Description
Added a condition to check if the stack name contains '180deg'.
If the stack is identified as the 180-degree stack, normalization is skipped, and a progress message is reported.
This prevents errors related to missing log files for the 180-degree stack.
Testing
Load a Dataset with a Log File: Loaded a dataset that includes both sample and 180-degree stacks with appropriate log files for the sample stack.
Perform Monitor Normalization:
Expected Behavior: Normalization is applied only to the sample stack.
Observed Behavior: The function successfully skips the 180-degree stack and applies normalization to the sample stack without errors.
Acceptance Criteria
Load a Dataset: Ensure that the dataset includes both sample and 180-degree stacks, with the log file available for the sample stack only.
Run Monitor Normalization: Execute the monitor normalization operation.
Check for Errors: Verify that no errors occur during the normalization process.
Documentation
Updated the release notes to include the bug fix for monitor normalization.