Unify datasets part 5 #2323
Merged
Unify datasets part 5 #2323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No difference between mixed and strict
samtygier-stfc
force-pushed
the
2199-unify-datasets-5
branch
from
7eec9d9 to
4cb12ea
Compare
|
Also using this PR to explore the changes from #2325 . Removing a test has triggered the expected "No current image" message on Applitools. |
Merged
MikeSullivan7
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Work on #2199
Description
This begins the work of simplifying use of datasets, now that they have not functional difference.
Rename BaseDataset to Dataset.
Remove menu differences.
Check if the dataset has a sample, rather than if it is a StrictDataset. (this fixes errors that could occur if you remove delete a sample from dataset)
Remove some type unions
Testing & Acceptance Criteria
MI starts and can open data.
"Load 180" should be enabled in the menu if a dataset is loaded.
Documentation
Not yet