Fix test test_replace_image_stack #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2333-fix-test-replace
branch
from
3d886ba to
0243d63
Compare
Merged
MikeSullivan7
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2333
Description
The issue was caused by not waiting for the new stack to finish loading. The delay was usually long enough but not always. When it was too slow, then
_add_images_to_existing_dataset()would run after the dataset had been deleted in thetearDown. This caused an error dialog which then confused the_click_messageBox()leading to a misleading error message.This resolves the issue by doing a proper
wait_until(), so that the test does not proceed until the stack is replaced.Also add a check for any left open
QMessageBoxorQDialog, so that this would be caught sooner, or get a better error.Testing
This fixes the tests
Acceptance Criteria
Tests should all pass
Documentation
Not needed, small fix up to #2317