Unify datasets 6 #2335
Merged
Unify datasets 6 #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2199-unify-datasets-6
branch
from
a851f5d to
747dfbb
Compare
samtygier-stfc
force-pushed
the
2199-unify-datasets-6
branch
from
fc42393 to
8bdd759
Compare
ashmeigh
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
I've reviewed the changes in this PR, focusing on the unified dataset handling and the removal of redundant parts. I tested the functionality for loading datasets to ensure they load and display correctly without any errors. I also checked the Nexus file-saving process, verifying that datasets are saved accurately with their data intact. Overall, these updates improve the code's maintainability and structure. In future work, there is potential for refining error-handling policies, particularly in Nexus saving, to ensure better clarity across the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
More work on #2199
Note needs to rebased after
#2323 #2334Description
Continues the cleanup. Unifies more code and removes unneeded parts.
Note this changes some of the screenshot tests.
Testing & Acceptance Criteria
This to test
Loading a dataset
Save as nexus file
Documentation
Not needed