Catch error for vectors of different length #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuiMacielPereira
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
We had reports of random Mantid crashes with the following stack trace:
Stack Trace: Traceback (most recent call last): File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/util/numpy_helper.py", line 14, in apply_with_corrected_shape return_value = method(shape_array, array) ValueError: operands could not be broadcast together with shapes (123,) (124,) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/plotting/plot_window/cut_plot.py", line 563, in show_intensity_plot if not self._run_temp_dependent(method, previous_type): File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/plotting/plot_window/cut_plot.py", line 576, in _run_temp_dependent cut_plotter_method(self._canvas.figure.axes[0]) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/presenters/cut_plotter_presenter.py", line 263, in show_dynamical_susceptibility self._show_intensity(self._cut_cache_dict[axes], IntensityType.CHI) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/presenters/cut_plotter_presenter.py", line 255, in _show_intensity self._plot_cut(workspace, cached_cut, plot_over=plot_over, intensity_correction=intensity_correction) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/presenters/cut_plotter_presenter.py", line 56, in _plot_cut cut_ws = cut.get_intensity_corrected_ws(intensity_correction) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/models/cut/cut.py", line 201, in get_intensity_corrected_ws return self.chi File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/models/cut/cut.py", line 157, in chi self._chi = compute_chi(self._cut_ws, self.sample_temp, self.e_axis) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/models/intensity_correction_algs.py", line 50, in compute_chi out = scattering_data * (chi / mag_scale) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/util/mantid/_workspace_ops.py", line 69, in op_wrapper return _binary_op(self, other, algorithm, result_info, inplace, reverse) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/util/mantid/_workspace_ops.py", line 48, in _binary_op inner_res = self._binary_op_array(_binary_operator_map[algorithm], other) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/workspace/histo_mixin.py", line 39, in _binary_op_array new_signal = apply_with_corrected_shape(operator, signal, other, array_size_error) File "/opt/mantidworkbench6.11/scripts/ExternalInterfaces/mslice/util/numpy_helper.py", line 22, in apply_with_corrected_shape elif shape_array.shape[1] == array.shape[1]: IndexError: tuple index out of range Using: workbench 6.11.0 on Rocky Linux 8.10 (Green Obsidian)Basically, there was an attempt to perform a binary operation on two vectors of different lengths. In this case, it is not possible to change the input arrays to match NumPy's broadcasting rules.
This PR adds a check to prevent this from happening.
To test:
Code review only.