Fix for bug in width calculation #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mducle
approved these changes
May 9, 2025
There was a problem hiding this comment.
Looks good and I confirm it fixes the issue.
I think that with this, the code where the original rounding error occurs (lines 145-146 of models/cut.py) is now unreachable and should probably be removed...
I agree, I will open a separate issue for it. |
This was referenced May 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Due to rounding errors MSlice sometimes assumed a set width for producing more than one cut when only one cut was intended. This has been fixed by setting the width to None if no value was provided.
To test:
Please replace MSlice in an installed Mantid with the version from this branch and follow steps in the original issue.
Fixes #39285 - Might need to get closed manually as it is a Mantid issue.