Fix for crash when changing GDOS on interactive cut #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuiMacielPereira
requested changes
May 20, 2025
There was a problem hiding this comment.
I followed the instructions on the original issue and now when Interactive Cuts is toggled the button for the Intensity is grey out, which means the user is not able to change intensity i.e. does not trigger the crash.
I have only a small suggestion to make the code a bit clearer.
Comment on lines
523
to
524
| def toggle_interactive_cuts(self, store=True): | ||
| self.toggle_icut_button(store) | ||
| self.toggle_icut_button(True) |
There was a problem hiding this comment.
Maybe delete the store argument since it's not used by the function anymore? And update the places where this function is being called with the argument?
SilkeSchomann
force-pushed
the
1071_fix_gdos_intensity_bug
branch
from
674429f to
42275e0
Compare
for more information, see https://pre-commit.ci
GuiMacielPereira
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
This fix includes two changes. The intensity on an interactive cut plot can only be changed when the
Interactive Cutsbutton on the original slice plot is toggled. This had the side-effect that the underlying cut workspace got deleted and was missing when attempting to change the intensity. Now this workspace remains available when the cut plot is still open.The second fix improves the functions that show a corrected intensity for a plot. The dictionary used to store the cut plots utilises
MSliceAxesobjects as keys. This sometimes causedKeyErrors, so these functions are now more robust when searching for the value for a key.To test:
Please replace MSlice in an installed Mantid with the version from this branch and follow steps in the original issue.
Fixes #1071.