38673 fix overplot exception #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilkeSchomann
force-pushed
the
38673_fix_overplot_exception
branch
from
0e3f3c8 to
7262a73
Compare
for more information, see https://pre-commit.ci
GuiMacielPereira
approved these changes
May 29, 2025
There was a problem hiding this comment.
Followed manual testing instructions and checked that taking a cut > change intensity > plot bragg peak > overplot does not cause a crash. Instead the plot correctly returns to its original state (without the bragg peak).
Also great that there is a new unit test 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
This PR fixes an unhandled exception that occurred when overplotting a cut with changed intensity and a Bragg peak.
To test:
Please replace MSlice in an installed Mantid with the version from this branch and follow steps in the original issue.
Please note that the Bragg peak is not supposed to get displayed after plotting over.
Fixes #38673.