Prevent crash for invalid characters #1089
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Looks good and stops the crashes in the original issue.
But, for the cuts - I don't see the warnings (in lines 121 / 126) in the UI at all (either run from the workbench or independently). I think some other parts of the code is just swallowing the warnings... but that's no reason to stop this PR.
Co-authored-by: Duc Le <duc.le@stfc.ac.uk>
The warnings are only displayed in the Message window of Mantid. |
Ah right... yes I see them now - I had my logging set to I'm not sure if it's a regression but now if the boxes are empty (the default) it will give the warnings whereas previously there was no warnings (it just plots the limits of the data - now it plots the limits of the data and gives a warning if the input is either empty or just contains the characters |
I've opened a new issue for displaying warnings on the MSlice GUI (#1090). I suggest we fix the Intensity box warnings as part of that. |
Description of work:
During manual testing, a few crashes were caused by entering invalid characters into the boxes for
BoseandScaleforComposeas well as forIntensityon theCuttab.To test:
Enter a special character into the boxes mentioned above and observe no crash, but a message warning about the invalid input. In case for the the
Intensity, the message differentiates between invalid entries for the start and end value.Fixes #1087