Hide vesuvio properties file #200
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running analysis, the input workspace can now be overriden by passing an extra argument containing the path of the file to override. This means that empty or raw runs will not be loaded and workspace is assumed to have been cropped already.
If the workspace is loaded using LoadAscii it will not contain geometry information necessary or multiscattering and gamma corrections
Will need this option in bootstrap, where hundreds of replicas will be created
Iterates over inputs directory and generates results in output directory
- As of now bootstrap runs the entire routine, i.e. analysis + fitting - Cleaned up run() method in analysis runner to be more versatile and easier to understand - Cleaned up search for workspaces that are meant to be fitted
If the workspace has zero errors, do not run minos or global fit since it's currently failing
The default config directory should not be exposed to the user (at least for now), which simplifies the setup of the config dir
Do the same routine as in joint but either only for backward or forward. Save paths using .absolute(), otherwise they're not saved in the right location
New file follows matplotlib style.
This way it's no longer accessible to users but most importantly, different packages share different cache files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Previously the state of the inputs and ip folder variables were being kept in a cache file
~/.mvesuvio/vesuvio.user.properties. However this meant that different packages or differnt versions of mvesuvio were sharing the same file.Since the scientists run workspaces on IDAaaS in parallel, several routines might be active at any time (from different packages) and the outputs paths were being messed up due to the file being shared amongst them.
this work puts the properties file inside the package without needing to copy it to the
.mvesuviofolder. this means that users can't edit it (which is good) and each package will use its own version of the file, solving the issue on IDAaaS.To test:
Fixes #xxxx.