Feature/enable dbsimm support #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change dependency to data-source
Update dependency to Data-source
Phocacius
reviewed
Jun 21, 2023
| "doctrine/persistence": "^1.3.0 || ^2", | ||
| "blueimp/jquery-file-upload": "9.*", | ||
| "mapbender/data-source": "~0.1.24 || ^0.2", | ||
| "mapbender/data-source": "dev-feature/enableDBSIMMSupport", |
There was a problem hiding this comment.
please revert this change, relying on a feature branch of another repo from the main branch is not a good idea
There was a problem hiding this comment.
Of course, this has to be adapted in case of merging. I just need the feature branches like this for the moment, since I rely on these changes and that unfortunately includes the dependency. What would be the appropriate way of handling this?
There was a problem hiding this comment.
probably releasing new versions of all packages at the same time. A composer update will then update all of the dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains minor changes that enable custom features from a project (method extraction for overriding purposes, additional parameters for methods). It may contain as well adaptions for doctrine 2.7.2 and removal of bugs.