Optimization: avoid generating data-driven fill-outline-color buffers if fill-antialias is false#12353
Draft
Optimization: avoid generating data-driven fill-outline-color buffers if fill-antialias is false#12353
fill-outline-color buffers if fill-antialias is false#12353Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick proof of concept to improve performance of styles that use data-driven
fill-colorin combination withfill-antialias: false: avoid generatingfill-outline-colorpaint buffers since they would duplicatefill-color(with notable GPU memory footprint on heavy layers likehillshade) but are not used in practice. Let's see if this makes a difference in benchmarks. Related: #10579Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes@mapbox/gl-nativeif this PR includes shader changes or needs a native portmapbox-gl-jschangelog:<changelog>Improve performance for fill layers with data-driven color and antialias: false</changelog>