proper use of deps for GenError

Author: mariadb-LeonidFedorov

dbcon/execplan/clientrotator.cpp

@@ -47,8 +47,6 @@ using namespace logging;
 
 #include "clientrotator.h"
 
-//#include "idb_mysql.h"
-
 /** Debug macro */
 #ifdef INFINIDB_DEBUG
 #define IDEBUG(x) \

dbcon/mysql/idb_mysql.h

@@ -14,10 +14,17 @@
    along with this program; if not, write to the Free Software
    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
    MA 02110-1301, USA. */
-// One include file to deal with all the MySQL pollution of the
-//  global namespace
-//
-// Don't include ANY mysql headers anywhere except here!
+
+/* One include file to deal with all the MySQL pollution of the
+   global namespace
+
+   Don't include ANY mysql headers anywhere except here!
+
+   WARN: if any cmake build target uses this include file,
+   GenError from server must be added to the target dependencies
+   to generate mysqld_error.h used below
+*/
+
 #pragma once
 
 #ifdef TEST_MCSCONFIG_H

utils/regr/CMakeLists.txt

@@ -25,7 +25,8 @@ columnstore_link(regr PRIVATE loggingcpp messageqcpp)
 
 set(regr_mysql_LIB_SRCS regrmysql.cpp modamysql.cpp)
 
+# Do anyone use it?
 columnstore_mysql_plugin_library(regr_mysql SHARED ${regr_mysql_LIB_SRCS})
-add_dependencies(regr_mysql external_boost)
+add_dependencies(regr_mysql external_boost GenError) # for "idb_mysql.h" that uses generated mysqld_error.h
 
 set_target_properties(regr_mysql PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/../../../)

utils/udfsdk/CMakeLists.txt

@@ -17,3 +17,5 @@ columnstore_link(udfsdk PRIVATE loggingcpp messageqcpp)
 add_definitions(-DMYSQL_DYNAMIC_PLUGIN)
 set(udf_mysql_LIB_SRCS udfmysql.cpp)
 columnstore_mysql_plugin_library(udf_mysql SHARED ${udf_mysql_LIB_SRCS})
+
+add_dependencies(udf_mysql GenError) # for "idb_mysql.h" that uses generated mysqld_error.h