Skip to content

Commit 4ce4e78

Browse files
Review fixes and ruff settings
1 parent 7c273c3 commit 4ce4e78

File tree

5 files changed

+30
-19
lines changed

5 files changed

+30
-19
lines changed

cmapi/cmapi_server/helpers.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import socket
1212
import time
1313
from collections import namedtuple
14-
from functools import partial
1514
from random import random
1615
from shutil import copyfile
1716
from typing import Tuple, Optional
@@ -603,11 +602,6 @@ def get_dbroots(node, config=DEFAULT_MCS_CONF_PATH):
603602
smc_node.find(f"./ModuleDBRootID{i}-{j}-3").text
604603
)
605604

606-
if dbroots and nc.is_read_only():
607-
logger = logging.getLogger('dbroots')
608-
logger.warning(f'Config contains dbroots {dbroots} for this read-only node, ignoring')
609-
return []
610-
611605
return dbroots
612606

613607

cmapi/cmapi_server/node_manipulation.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ def _remove_node(root, node):
398398
for n in (root.find("./DesiredNodes"), root.find("./InactiveNodes"), root.find("./ActiveNodes")):
399399
__remove_helper(n, node)
400400

401-
read_only_nodes = root.find("./ReadOnlyNodes")
401+
read_only_nodes = root.find('./ReadOnlyNodes')
402402
if read_only_nodes is not None:
403403
__remove_helper(read_only_nodes, node)
404404

@@ -1015,11 +1015,11 @@ def _add_WES(root, pm_num, node):
10151015
etree.SubElement(wes_node, "Port").text = "8630"
10161016

10171017

1018-
def _add_read_only_node(root, node) -> None:
1019-
"""Add node name to ReadOnlyNodes if it's not already there"""
1020-
read_only_nodes = root.find("./ReadOnlyNodes")
1018+
def _add_read_only_node(root: etree.Element, node: str) -> None:
1019+
'''Add node name to ReadOnlyNodes if it is not already there'''
1020+
read_only_nodes = root.find('./ReadOnlyNodes')
10211021
if read_only_nodes is None:
1022-
read_only_nodes = etree.SubElement(root, "ReadOnlyNodes")
1022+
read_only_nodes = etree.SubElement(root, 'ReadOnlyNodes')
10231023
else:
10241024
for n in read_only_nodes.findall("./Node"):
10251025
if n.text == node:

cmapi/cmapi_server/test/test_node_manip.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import logging
22
import socket
33
import unittest
4-
from unittest.mock import patch
4+
from unittest.mock import patch, ANY
55
from lxml import etree
66

77
from cmapi_server import node_manipulation
@@ -97,7 +97,7 @@ def test_add_remove_read_only_node(self):
9797

9898
mock_rebalance_dbroots.assert_not_called()
9999
mock_move_primary_node.assert_not_called()
100-
mock_add_dbroots_of_other_nodes.assert_called_once_with(root, 2)
100+
mock_add_dbroots_of_other_nodes.assert_called_once_with(ANY, 2)
101101

102102
# Test read-only node removal
103103
node_manipulation.remove_node(
@@ -111,7 +111,7 @@ def test_add_remove_read_only_node(self):
111111

112112
mock_rebalance_dbroots.assert_not_called()
113113
mock_move_primary_node.assert_not_called()
114-
mock_remove_dbroots_of_node.assert_called_once_with(root, 2)
114+
mock_remove_dbroots_of_node.assert_called_once_with(ANY, 2)
115115

116116

117117
def test_add_dbroots_nodes_rebalance(self):

cmapi/mcs_node_control/models/node_config.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -567,11 +567,6 @@ def get_all_dbroots(self, root):
567567
for j in range(1, int(smc_node.find(f"./ModuleDBRootCount{i}-3").text) + 1):
568568
dbroots.append(smc_node.find(f"./ModuleDBRootID{i}-{j}-3").text)
569569

570-
# TODO not sure about it
571-
if dbroots and self.is_read_only(root):
572-
module_logger.warning("Config contains dbroots %s for this read-only node, ignoring", dbroots)
573-
return []
574-
575570
return dbroots
576571

577572
def is_read_only(self, root=None) -> bool:

cmapi/pyproject.toml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
[tool.ruff]
2+
line-length = 80
3+
target-version = "py39"
4+
# Enable common rule sets
5+
select = [
6+
"E", # pycodestyle errors
7+
"F", # pyflakes: undefined names, unused imports, etc.
8+
"I", # isort: import sorting
9+
"B", # flake8-bugbear: common bugs and anti-patterns
10+
"UP", # pyupgrade: use modern Python syntax
11+
"N", # pep8-naming: naming conventions
12+
]
13+
14+
ignore = []
15+
16+
# Exclude cache and temporary directories
17+
exclude = [
18+
"__pycache__",
19+
]
20+
21+
[tool.ruff.format]
22+
quote-style = "single"

0 commit comments

Comments
 (0)