chore(build): better build pipeline #3584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -479,19 +510,28 @@ build_binary() { | |||
| message "Configuring cmake silently" | |||
| ${CMAKE_BIN_NAME} "${MDB_CMAKE_FLAGS[@]}" -S"$MDB_SOURCE_PATH" -B"$MARIA_BUILD_PATH" | spinner | |||
| message_split | |||
| check_debian_install_file | |||
| # check_debian_install_file // will be uncommented later | |||
There was a problem hiding this comment.
Did you forget to uncomment it? Or by later you mean sometime after merging this?
| message "Installing silently" | ||
| cd $MDB_SOURCE_PATH | ||
| ${CMAKE_BIN_NAME} --install "$MARIA_BUILD_PATH" | spinner 30 | ||
| check_errorcode |
There was a problem hiding this comment.
maybe it is better use trap command to catch exit signal and call build failure error printing? This way you won't need to call check_errorcode every time
See build_cmapi.sh:39-46
| modify_packaging | ||
| build_package | ||
| message_splitted "PACKAGES BUILD FINISHED" |
There was a problem hiding this comment.
maybe put this inside of build_package?
mariadb-AlekseiBukhalov
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for
#3564