Skip to content

Database groups #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Database groups #23

wants to merge 6 commits into from

Conversation

langbeinmovio
Copy link

Main feature: configure groups of databases, include/exclude groups of database. See updated README for usage.

Other changes:

  • configure maximum number of concurrent requests via same AppServer
  • update dependencies in build docker container
  • fix build status on README

marianogappa
marianogappa approved these changes Jul 22, 2021
View reviewed changes
Copy link
Owner

@marianogappa marianogappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for contributing! 👍 How about keeping the camelCase for the JSON? I added suggestions for how to do it in the struct, but will require changes on the example. Otherwise do merge it.

config.go
const DefaultMaxAppServerConnections = 5

type settings struct {
MaxAppServerConnections int64
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MaxAppServerConnections int64
MaxAppServerConnections int64 `json:"maxAppServerConnections"`

config.go

type settings struct {
MaxAppServerConnections int64
Databases map[string]database
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Databases map[string]database
Databases map[string]database `json:"databases"`

config.go
type settings struct {
MaxAppServerConnections int64
Databases map[string]database
DatabaseGroups map[string][]string
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DatabaseGroups map[string][]string
DatabaseGroups map[string][]string `json:"databaseGroups"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianogappa marianogappa marianogappa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langbeinmovio @marianogappa