Skip to content

Conversation

mwynn1
Copy link

@mwynn1 mwynn1 commented Oct 13, 2025

📝 Summary

Retain column metadata on cells when switching from columns width to another width type in settings

Fixes #3543

🔍 Description of Changes

Remove the mergeAllColumn call in edit-app.txt on width change.

after toggling to medium width from columns
image

after toggling back to columns width

image

📋 Checklist

  • [x ] I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

Copy link

vercel bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 13, 2025 3:02am

Copy link

github-actions bot commented Oct 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mwynn1
Copy link
Author

mwynn1 commented Oct 13, 2025

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code change looks good to me (assuming it does work)

@Light2Dark
Copy link
Contributor

this leads to the main view having separate sections, like in the first screenshot you took.
I think one option is in cells.ts:L1442, we don't reset the cell config's column.

        return {
          ...cells[cellId].config,
          // Preserve the original column if it exists
          column: originalColumn === undefined ? null: originalColumn
        };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switching from columns view to another view loses column metadata

3 participants