Skip to content

Do not merge cols when toggling from column width. #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Do not merge cols when toggling from column width. #6752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
892bd9a
Do not merge cols when toggling from column width.
mwynn1 Oct 13, 2025
9d5c6de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions frontend/src/core/edit-app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/* Copyright 2024 Marimo. All rights reserved. */

import { usePrevious } from "@dnd-kit/utilities";
import { TooltipProvider } from "@radix-ui/react-tooltip";
import { useAtomValue, useSetAtom } from "jotai";
import { useEffect } from "react";
Expand Down Expand Up @@ -101,14 +100,6 @@ export const EditApp: React.FC<AppProps> = ({
"Untitled Notebook";
}, [appConfig.app_title, filename]);

// Delete column breakpoints if app width changes from "columns"
const previousWidth = usePrevious(appConfig.width);
useEffect(() => {
if (previousWidth === "columns" && appConfig.width !== "columns") {
mergeAllColumns();
}
}, [appConfig.width, previousWidth, mergeAllColumns, numColumns]);

const runStaleCells = useRunStaleCells();
const runAllCells = useRunAllCells();
const togglePresenting = useTogglePresenting();
Expand Down
Loading