Skip to content

feat: blank targets on links#114

Open
jeromebon wants to merge 2 commits intomarko-js:mainfrom
jeromebon:blank-targets
Open

feat: blank targets on links#114
jeromebon wants to merge 2 commits intomarko-js:mainfrom
jeromebon:blank-targets

Conversation

@jeromebon
Copy link
Contributor

No description provided.

@LuLaValva
Copy link
Member

Is this really something we want? User can always choose to open links in a new tab using keyboard shortcuts or right-click, so forcing _blank actually limits options instead of adding them.

If we do add _blank for external links, we should definitely add affordance to let users know what is going on (maybe this icon after the text)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants