Add method to check for decoding errors#287
Open
tcerqueira wants to merge 2 commits intomarshallpierce:masterfrom
Open
Add method to check for decoding errors#287tcerqueira wants to merge 2 commits intomarshallpierce:masterfrom
tcerqueira wants to merge 2 commits intomarshallpierce:masterfrom
Conversation
Author
|
@marshallpierce do you have any suggestion on the best solution to throw the proper error? |
Author
|
Benchamarks show it's slower than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature for #286
check_encodedmethod toEnginetrait.The tests
decode_invalid_trailing_bytesare failing because the error for decoding does not match with check implementation. I don't know if it's necessarily incorrect but it's definitely less useful error compared to the decode implementation. Either way, I think the check should error the same way as decode, for everyone's sanity.The msrv build fails because of range pattern syntax.