Skip to content

Conversation

tcerqueira
Copy link

@tcerqueira tcerqueira commented Jun 21, 2025

Feature for #286

  • Add check_encoded method to Engine trait.
  • Implement feature for all engines.
  • Add tests
  • Add benchmarks

The tests decode_invalid_trailing_bytes are failing because the error for decoding does not match with check implementation. I don't know if it's necessarily incorrect but it's definitely less useful error compared to the decode implementation. Either way, I think the check should error the same way as decode, for everyone's sanity.

The msrv build fails because of range pattern syntax.

@tcerqueira
Copy link
Author

@marshallpierce do you have any suggestion on the best solution to throw the proper error?

@tcerqueira
Copy link
Author

Benchamarks show it's slower than decode_slice 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant