Ui_imp add Array/Object params #203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Raise against main. |
jas34
reviewed
Oct 21, 2025
There was a problem hiding this comment.
Overall suggestion:
- pre-loaded agent in AgC UI is fine to get first hand experience of tools, prompt. But it can't run directly.
- E2E execution agent is dependent on tools which runs in separate run time.... it is better to provide setup instructions as a response of query to agent on AgC UI.
- Setup instructions can be documented in ReadMe.
- E2E execution of use case should be from main function written inside module telco-revenue-retention. This will call agent first through Responses API, using openAI agent SDK.
- Since, this runtime has tools too then tools would also get executed as when called by AgC.
platform/agc-platform-core/src/main/resources/bootstrap-agents.json
Outdated
Show resolved
Hide resolved
platform/examples/sdk-examples/openai-java-sdk/build.gradle.kts
Outdated
Show resolved
Hide resolved
platform/examples/sdk-examples/openai-java-sdk/src/main/java/common/AgcRuntimeTool.java
Outdated
Show resolved
Hide resolved
jas34
reviewed
Oct 22, 2025
platform/agc-platform-core/src/main/kotlin/ai/masaic/platform/api/service/AgentService.kt
Outdated
Show resolved
Hide resolved
platform/agc-platform-core/src/main/kotlin/ai/masaic/platform/api/service/AgentService.kt
Outdated
Show resolved
Hide resolved
| "strict": true | ||
| } | ||
| ], | ||
| "model":"gpt-4o", |
There was a problem hiding this comment.
change with gpt-4.1-mini .... :P ... you know the reason :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.