Skip to content

Consider cases without icon for selected item in Lookup for SLDS2 #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

msmx-mnakagawa
Copy link
Collaborator

What I did

  • switch the has-icon_ classname based on whether the selected item has an icon

@msmx-mnakagawa msmx-mnakagawa self-assigned this Aug 5, 2025
Copy link

reg-suit bot commented Aug 5, 2025

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

@msmx-mnakagawa msmx-mnakagawa requested a review from stomita August 5, 2025 05:25
@msmx-mnakagawa msmx-mnakagawa marked this pull request as ready for review August 5, 2025 05:25
@stomita stomita merged commit 278ddbe into master Aug 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants