Skip to content

Conversation

pakhomovalex
Copy link

Copy link

@GUSILLUS GUSILLUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Just try to make all ui more similar to design)

@pakhomovalex pakhomovalex requested a review from GUSILLUS April 5, 2024 09:36
Copy link

@GUSILLUS GUSILLUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! But:

1, Consider adding some alert logic to buttons
image

  1. Can we remove cursor pointer from images? Just because we don't have any on click logic
    image

  2. Try to fix andy on table from this
    image
    to this
    image

  3. Try to make gradient more smooth
    image
    like in design
    image

  4. Try to think how we can save this logic but not to block a buttons behind the picture [optional more in the add to portfolio step]
    image

  5. Check why you have horizontal scroll in mobile view
    image

@pakhomovalex pakhomovalex requested a review from GUSILLUS April 8, 2024 17:19
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just couple tiny things needs to be fixed before approval)

  1. address link must open in new tab
    image
  2. remove autofill styles
    image
  3. would be nice to add some fav icon
    image

@pakhomovalex
Copy link
Author

I don't know, how I can remove autofill styles, I tried use autocomplete = "off", but how I understand it`s not working

@pakhomovalex pakhomovalex requested a review from maxim2310 April 8, 2024 18:07
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could check it here or if you want ask in fe chat
https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/

@pakhomovalex pakhomovalex requested a review from maxim2310 April 8, 2024 18:45
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!
To improve:

  1. This link should be open in the new tab
image
  1. The yellow background color should be pressed against the right and left sides of the browser window
image
  1. The yellow background color should be pressed against the left side of the browser windowв
image

Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress! I approve it but check my suggestion

could be cursor pointer to let user know it is clickable
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants