hibernate-user-service-hw v(1.0); #867
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added customs exceptions;
-added user class;
-added HashUtil class with hashPassword() method;
-modified HashUtil class adding getsalt() method; -some changes in User.class;
-all tasks completed;
Elena-Bruyako
suggested changes
Aug 29, 2024
| @@ -44,7 +59,8 @@ public static void main(String[] args) { | |||
| yesterdayMovieSession.setMovie(fastAndFurious); | |||
| yesterdayMovieSession.setShowTime(LocalDateTime.now().minusDays(1L)); | |||
|
|
|||
| MovieSessionService movieSessionService = null; | |||
| MovieSessionService movieSessionService = | |||
| (MovieSessionService) INJECTOR.getInstance(MovieSessionService.class); | |||
There was a problem hiding this comment.
In the mate/academy/Main.main() method create an instance of AuthenticationService using injector and test all methods from it.
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
| private String login; |
There was a problem hiding this comment.
Suggested change
| private String login; | |
| private String email; |
Let's make the email unique. We need to check the email during user registration and make the email a unique field in the database.
|
|
||
| } | ||
|
|
||
| public User authenticate(String login, String password) { |
Comment on lines
19
to
22
| User user = new User(); | ||
| user.setLogin(login); | ||
| user.setPassword(password); | ||
| return userService.save(user); |
There was a problem hiding this comment.
Suggested change
| User user = new User(); | |
| user.setLogin(login); | |
| user.setPassword(password); | |
| return userService.save(user); | |
| validateRegisterData(email, password); | |
| return userService.save(new User(email, password)); |
|
|
||
| @Override | ||
| public User login(String login, String password) { | ||
| Optional<User> userByLogin = userService.findByLogin(login); |
There was a problem hiding this comment.
Suggested change
| Optional<User> userByLogin = userService.findByLogin(login); | |
| Optional<User> user = userService.findByEmail(email); | |
| if (user.isEmpty() || !isValidPassword(user.get(), password)) { | |
| throw new AuthenticationException( | |
| "Authentication failed for user with email: " + email); | |
| } | |
| return user.get(); |
where
private boolean isValidPassword(User user, String password) {
return password != null && user.getPassword()
.equals(HashUtil.hashPassword(password, user.getSalt()));
}
| hashedPassword.append(String.format("%02x", b)); | ||
| } | ||
| } catch (NoSuchAlgorithmException e) { | ||
| throw new IllegalStateException("Could not create hash using SHA-512 algorithm", e); |
There was a problem hiding this comment.
use your constant CRYPTO_ALGORITHM in message
Changes after review of mentor Olena. - used constant CRYPTO_ALGORITHGM in throw message; -modified logic in register and login method:
-added a check before registration whether such an email exists in the database;
okuzan
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.