Update project #1591
Update project #1591
Conversation
There was a problem hiding this comment.
Review Summary
REQUEST_CHANGES
The implementation is very strong overall, but there is a critical checklist violation that needs to be addressed before approval:
- The
hashCode(K key)method inMyHashMap.javais declared aspublic, but it is only used internally. According to the requirements, utility methods that are only used internally should not be public; you should use the most restrictive access modifier possible. This is an explicit checklist item and must be followed for full compliance.
How to fix:
- Change the access modifier of
hashCode(K key)frompublictoprivateinMyHashMap.java.
This is a quick fix, but it's important for encapsulation and meeting the assignment's requirements. Once you make this change, your implementation will be fully compliant. Great job on the rest of the code—you're very close to approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| } | ||
|
|
||
| @Override | ||
| public int hashCode(K key) { |
There was a problem hiding this comment.
The method 'hashCode(K key)' is declared as public, but according to the requirements, utility methods and classes that are only used internally should not be public; use the most restrictive access modifier possible. This violates checklist item: 'Utility methods and classes that are only used internally should not be public; use the most restrictive access modifier possible.' Consider making this method private.
There was a problem hiding this comment.
Review Summary
All core requirements for the custom MyHashMap implementation are fully met. The code correctly implements the required methods (put, getValue, getSize), handles resizing and load factor logic, and follows all technical and style guidelines outlined in the assignment. The previous issue regarding access modifiers has been resolved, and there are no critical blockers or missing features. Great job on a clean, well-structured, and standards-compliant solution!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
No description provided.