Added classes Ball, Lottery, ColorSupplier; Enum DiiferentColors and … #1572
Conversation
…realised method main
There was a problem hiding this comment.
Great job following the checklist guidelines in your Application.java file! 🎉 Your code is functional and meets the core requirements. Just a couple of suggestions for the future: try using name() for enums to get their string representation as it's safer in case toString() gets overridden, and consider reusing a single Random instance for efficiency. Keep up the good work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| int index = new Random().nextInt(DifferentColors.values().length); |
There was a problem hiding this comment.
Creating a new instance of Random for every method call is inefficient. Consider creating a single Random instance as a class field and reusing it.
| return null; | ||
| int index = new Random().nextInt(DifferentColors.values().length); | ||
| DifferentColors ballColor = DifferentColors.values()[index]; | ||
| return ballColor.toString(); |
There was a problem hiding this comment.
Instead of using toString(), it's better to use name() for getting the String representation of enum constants to avoid issues if toString() is overridden.
…realised method main
…realised method main