lottety-hw-01 #1575

aunkerrr · 2024-08-16T16:21:00Z

No description provided.

mateacademy-ai-mentor

Great job on implementing the Application and Ball classes! 😊 Your use of the enum's name() method in the Ball class is spot-on for getting the color representation. As suggested, consider using loops to handle repetitive tasks in the future to make your code even more efficient and maintainable. Keep up the good work! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-08-16T16:21:23Z

src/main/java/core/basesyntax/Application.java

+        Ball ball1 = lottery.getRandomBall();
+        Ball ball2 = lottery.getRandomBall();
+        Ball ball3 = lottery.getRandomBall();
+
+        System.out.println(ball1);
+        System.out.println(ball2);
+        System.out.println(ball3);


Instead of creating multiple Ball instances separately, consider using a for-loop to create and print the balls. This will make the code more concise and easier to maintain if you need to generate a different number of balls in the future. Refer to the checklist about using a for loop for creating several objects of the same class.

mateacademy-ai-mentor · 2024-08-16T16:21:23Z

src/main/java/core/basesyntax/ColorSupplier.java

-    public String getRandomColor() {
-        return null;
+    public Color getRandomColor() {
+        Random random = new Random();


Creating a new instance of 'Random' each time the method is called can be inefficient if the method is called multiple times. Consider making 'random' a class-level instance variable.

fix comment

mateacademy-ai-mentor · 2024-08-16T16:21:23Z

src/main/java/core/basesyntax/Lottery.java

+
+import java.util.Random;
+
+class Lottery {


Classes must have access modifiers; otherwise, the default will be used, which isn't a good practice. Consider adding an access modifier to the Lottery class.

mateacademy-ai-mentor · 2024-08-16T16:21:23Z

src/main/java/core/basesyntax/Lottery.java

+
+class Lottery {
+    public Ball getRandomBall() {
+        Random random = new Random();


The instance of Random could be a class-level field instead of being created every time the 'getRandomBall' method is called. This would be more efficient as it avoids unnecessary object creation.

fix comment

mateacademy-ai-mentor · 2024-08-16T16:21:23Z

src/main/java/core/basesyntax/Lottery.java

+class Lottery {
+    public Ball getRandomBall() {
+        Random random = new Random();
+        Color color = new ColorSupplier().getRandomColor();


Creating a new instance of ColorSupplier every time may be inefficient if the getRandomColor method does not depend on instance state. Consider making ColorSupplier a class-level field or its method static if there's no state.

fix comment

mateacademy-ai-mentor · 2024-08-16T16:21:23Z

src/main/java/core/basesyntax/Lottery.java

+    public Ball getRandomBall() {
+        Random random = new Random();
+        Color color = new ColorSupplier().getRandomColor();
+        int number = random.nextInt(101);


Magic numbers should be avoided and replaced with named constants for better code readability. Consider creating a constant for the number 101, giving it a meaningful name that explains what it represents.

fix comment

Elena-Bruyako · 2024-08-16T21:11:05Z

src/main/java/core/basesyntax/Application.java

    public static void main(String[] args) {
-        // create three balls using class Lottery and print information about them in console
+        Lottery lottery = new Lottery();
+        Ball ball1 = lottery.getRandomBall();


Please use for loop.
if you have 100 balls, you won't need to create 100 lines of code

Elena-Bruyako · 2024-08-16T21:11:15Z

src/main/java/core/basesyntax/Ball.java

+package core.basesyntax;
+
+public class Ball {
+    private Color color;


Suggested change

private Color color;

private String color;

Elena-Bruyako · 2024-08-16T21:11:36Z

src/main/java/core/basesyntax/Color.java

+package core.basesyntax;
+
+public enum Color {
+        RED, GREEN, BLUE, YELLOW, ORANGE, BLACK, WHITE


Suggested change

RED, GREEN, BLUE, YELLOW, ORANGE, BLACK, WHITE

RED,

GREEN,

BLUE,

YELLOW,

ORANGE,

BLACK,

WHITE

Elena-Bruyako · 2024-08-16T21:11:45Z

src/main/java/core/basesyntax/ColorSupplier.java

 public class ColorSupplier {
-    public String getRandomColor() {
-        return null;
+    public Color getRandomColor() {


Suggested change

public Color getRandomColor() {

public String getRandomColor() {

Elena-Bruyako · 2024-08-16T21:11:54Z

src/main/java/core/basesyntax/ColorSupplier.java

-    public String getRandomColor() {
-        return null;
+    public Color getRandomColor() {
+        Random random = new Random();


fix comment

Elena-Bruyako · 2024-08-16T21:12:01Z

src/main/java/core/basesyntax/Lottery.java

+    public Ball getRandomBall() {
+        Random random = new Random();
+        Color color = new ColorSupplier().getRandomColor();
+        int number = random.nextInt(101);


fix comment

Elena-Bruyako · 2024-08-16T21:12:13Z

src/main/java/core/basesyntax/Lottery.java

+
+class Lottery {
+    public Ball getRandomBall() {
+        Random random = new Random();


fix comment

Elena-Bruyako · 2024-08-16T21:12:17Z

src/main/java/core/basesyntax/Lottery.java

+class Lottery {
+    public Ball getRandomBall() {
+        Random random = new Random();
+        Color color = new ColorSupplier().getRandomColor();


fix comment

Elena-Bruyako · 2024-08-19T14:54:03Z

src/main/java/core/basesyntax/Application.java

+
+        Lottery lottery = new Lottery();
+
+        for (int i = 0; i < 3; i++) {


3 is a magic number, create constant

Elena-Bruyako · 2024-08-19T14:54:16Z

src/main/java/core/basesyntax/Application.java

+            Ball ball = lottery.getRandomBall();
+            System.out.println(ball);


Suggested change

Ball ball = lottery.getRandomBall();

System.out.println(ball);

System.out.println(lottery.getRandomBall());

Elena-Bruyako · 2024-08-19T14:54:24Z

src/main/java/core/basesyntax/Ball.java

+    private String color;
+    private int number;
+
+    public Ball(Color color, int number) {


Suggested change

public Ball(Color color, int number) {

public Ball(String color, int number) {

Elena-Bruyako · 2024-08-19T14:54:32Z

src/main/java/core/basesyntax/Ball.java

+
+    public Ball(Color color, int number) {
+        this.number = number;
+        this.color = String.valueOf(color);


Suggested change

this.color = String.valueOf(color);

this.color = color;

Elena-Bruyako · 2024-08-19T14:54:40Z

src/main/java/core/basesyntax/ColorSupplier.java

 public class ColorSupplier {
-    public String getRandomColor() {
-        return null;
+    public Color getRandomColor() {


Elena-Bruyako · 2024-08-19T14:54:48Z

src/main/java/core/basesyntax/Lottery.java

+    public Ball getRandomBall() {
+        Random random = new Random();
+        Color color = new ColorSupplier().getRandomColor();
+        int number = random.nextInt(101);


Elena-Bruyako · 2024-08-19T14:55:05Z

src/main/java/core/basesyntax/Lottery.java

+
+class Lottery {
+    private Random random = new Random();
+    private Color color = new ColorSupplier().getRandomColor();


Suggested change

private Color color = new ColorSupplier().getRandomColor();

private ColorSupplier colorSupplier = new ColorSupplier();

Elena-Bruyako · 2024-08-19T14:55:39Z

src/main/java/core/basesyntax/Lottery.java

+
+    public Ball getRandomBall() {
+        int number = random.nextInt(101);
+        return new Ball(color, number);


Suggested change

return new Ball(color, number);

String randomColor = colorSupplier.getRandomColor();

return new Ball(randomColor, number);

MentorMateAcademy · 2024-08-26T10:26:39Z

src/main/java/core/basesyntax/ColorSupplier.java

+    public Color getRandomColor() {
+        Color[] colors = Color.values();
+        return colors[random.nextInt(colors.length)];


return in String type

MentorMateAcademy · 2024-08-26T10:27:06Z

src/main/java/core/basesyntax/Lottery.java

+
+    public Ball getRandomBall() {
+        int number = random.nextInt(101);


Save to constant

MentorMateAcademy · 2024-08-28T10:48:21Z

src/main/java/core/basesyntax/Lottery.java

+
+    public Ball getRandomBall() {
+        int number = random.nextInt(maxValue);
+        String randomColor = String.valueOf(colorSupplier.getRandomColor());


Suggested change

String randomColor = String.valueOf(colorSupplier.getRandomColor());

String randomColor = colorSupplier.getRandomColor();

Elena-Bruyako · 2024-08-28T11:53:14Z

src/main/java/core/basesyntax/Application.java

 public class Application {
    public static void main(String[] args) {
-        // create three balls using class Lottery and print information about them in console
+        int ballsNumber = 3;


it should be constant

Elena-Bruyako · 2024-08-28T11:53:25Z

src/main/java/core/basesyntax/Color.java

+package core.basesyntax;
+
+public enum Color {
+        RED, GREEN, BLUE, YELLOW, ORANGE, BLACK, WHITE


Elena-Bruyako · 2024-08-28T11:53:53Z

src/main/java/core/basesyntax/ColorSupplier.java

+
    public String getRandomColor() {
-        return null;
+        Color[] colors = Color.values();


you can create it as class-level variable

Elena-Bruyako · 2024-08-28T11:54:01Z

src/main/java/core/basesyntax/Lottery.java

+
+import java.util.Random;
+
+class Lottery {


Suggested change

class Lottery {

public class Lottery {

Elena-Bruyako · 2024-08-28T11:54:07Z

src/main/java/core/basesyntax/Lottery.java

+import java.util.Random;
+
+class Lottery {
+    private int maxValue = 101;


make it constant

lottety-hw-01

d9ca0e4

mateacademy-ai-mentor approved these changes Aug 16, 2024

View reviewed changes

Elena-Bruyako suggested changes Aug 16, 2024

View reviewed changes

lottety-hw-02

b1dd9a7

aunkerrr requested a review from mateacademy-ai-mentor August 19, 2024 01:56

Elena-Bruyako suggested changes Aug 19, 2024

View reviewed changes

lottety-hw-03

f3a28e3

aunkerrr requested a review from Elena-Bruyako August 25, 2024 22:21

MentorMateAcademy suggested changes Aug 26, 2024

View reviewed changes

lottety-hw-02

c0470dc

aunkerrr requested a review from MentorMateAcademy August 27, 2024 15:58

MentorMateAcademy suggested changes Aug 28, 2024

View reviewed changes

aunkerrr requested a review from MentorMateAcademy August 28, 2024 11:42

lottety-hw-05

2ef4b82

Elena-Bruyako suggested changes Aug 28, 2024

View reviewed changes

lottety-hw-06

5f9c9c4

aunkerrr requested a review from Elena-Bruyako August 29, 2024 00:07

MentorMateAcademy approved these changes Aug 29, 2024

View reviewed changes

	public Color getRandomColor() {
	public String getRandomColor() {


		Lottery lottery = new Lottery();

		for (int i = 0; i < 3; i++) {

		Ball ball = lottery.getRandomBall();
		System.out.println(ball);

	Ball ball = lottery.getRandomBall();
	System.out.println(ball);
	System.out.println(lottery.getRandomBall());

	public Ball(Color color, int number) {
	public Ball(String color, int number) {

	private Color color = new ColorSupplier().getRandomColor();
	private ColorSupplier colorSupplier = new ColorSupplier();

	return new Ball(color, number);
	String randomColor = colorSupplier.getRandomColor();
	return new Ball(randomColor, number);


		public Ball getRandomBall() {
		int number = random.nextInt(101);

	String randomColor = String.valueOf(colorSupplier.getRandomColor());
	String randomColor = colorSupplier.getRandomColor();

lottety-hw-01 #1575

Are you sure you want to change the base?

lottety-hw-01 #1575

Uh oh!

Conversation

aunkerrr commented Aug 16, 2024

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!