Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

public class Application {
public static void main(String[] args) {
// create three balls using class Lottery and print information about them in console

Lottery lottery = new Lottery();

for (int i = 0; i < 3; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 is a magic number, create constant

Ball ball = lottery.getRandomBall();
System.out.println(ball);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ball ball = lottery.getRandomBall();
System.out.println(ball);
System.out.println(lottery.getRandomBall());

}
}
}
19 changes: 19 additions & 0 deletions src/main/java/core/basesyntax/Ball.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package core.basesyntax;

public class Ball {
private String color;
private int number;

public Ball(Color color, int number) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public Ball(Color color, int number) {
public Ball(String color, int number) {

this.number = number;
this.color = String.valueOf(color);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.color = String.valueOf(color);
this.color = color;

}

@Override
public String toString() {
return "Ball{"
+ "color=" + color
+ ", number=" + number
+ '}';
}
}
5 changes: 5 additions & 0 deletions src/main/java/core/basesyntax/Color.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package core.basesyntax;

public enum Color {
RED, GREEN, BLUE, YELLOW, ORANGE, BLACK, WHITE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RED, GREEN, BLUE, YELLOW, ORANGE, BLACK, WHITE
RED,
GREEN,
BLUE,
YELLOW,
ORANGE,
BLACK,
WHITE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

}
9 changes: 7 additions & 2 deletions src/main/java/core/basesyntax/ColorSupplier.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
package core.basesyntax;

import java.util.Random;

public class ColorSupplier {
public String getRandomColor() {
return null;
private Random random = new Random();

public Color getRandomColor() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public Color getRandomColor() {
public String getRandomColor() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

Color[] colors = Color.values();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can create it as class-level variable

return colors[random.nextInt(colors.length)];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return in String type

}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Lottery.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

import java.util.Random;

class Lottery {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classes must have access modifiers; otherwise, the default will be used, which isn't a good practice. Consider adding an access modifier to the Lottery class.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Lottery {
public class Lottery {

private Random random = new Random();
private Color color = new ColorSupplier().getRandomColor();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private Color color = new ColorSupplier().getRandomColor();
private ColorSupplier colorSupplier = new ColorSupplier();


public Ball getRandomBall() {
int number = random.nextInt(101);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic numbers should be avoided and replaced with named constants for better code readability. Consider creating a constant for the number 101, giving it a meaningful name that explains what it represents.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Save to constant

return new Ball(color, number);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return new Ball(color, number);
String randomColor = colorSupplier.getRandomColor();
return new Ball(randomColor, number);

}
}
Loading