apply solution #1578
Open
apply solution #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1sam
reviewed
Mar 5, 2025
|
|
||
| public String getRandomColor() { | ||
| return null; | ||
| return Color.values()[new Random().nextInt(0, Color.values().length)].name(); |
There was a problem hiding this comment.
please make random object as a class member
d1sam
reviewed
Mar 5, 2025
| public class Lottery { | ||
|
|
||
| public Ball getRandomBall() { | ||
| return new Ball(new ColorSupplier().getRandomColor(), new Random().nextInt(0, 100)); |
There was a problem hiding this comment.
please make ColorSupplier and Random object as a class members.
please do not use magic number, and think about upper number (maybe 101?)
d1sam
suggested changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.