created classes,enum and solved the task #1579
Conversation
There was a problem hiding this comment.
Great job on following the checklist guidelines and ensuring your code is clean and well-structured! 👍 Just a couple of tips for future improvements: remember to reuse arrays created by methods like Color.values() by storing them in a local variable if you're going to use them multiple times. Also, for better performance and resource management, consider making the Random instance a static constant if your class is used frequently. Keep up the good work! 💻🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| private Random random = new Random(); |
There was a problem hiding this comment.
Consider moving the 'Random' instance to be a class-level constant, since it does not need to be instantiated multiple times if the 'ColorSupplier' class is used multiple times.
| int index = random.nextInt(Color.values().length); | ||
| return Color.values()[index]; |
There was a problem hiding this comment.
You're calling 'Color.values()' twice which creates a new array each time it's called. It's better to store it in a local variable and reuse it.
| // create three balls using class Lottery and print information about them in console | ||
| Lottery lottery = new Lottery(); | ||
|
|
||
| Ball ball1 = lottery.getRandomBall(); |
| package core.basesyntax; | ||
|
|
||
| public class Ball { | ||
| private Color color; |
There was a problem hiding this comment.
| private Color color; | |
| private String color; |
| return null; | ||
| private Random random = new Random(); | ||
|
|
||
| public Color getRandomColor() { |
There was a problem hiding this comment.
| public Color getRandomColor() { | |
| public String getRandomColor() { |
|
|
||
| public Ball getRandomBall() { | ||
| Color color = colorSupplier.getRandomColor(); | ||
| int number = random.nextInt(100) + 1; |
There was a problem hiding this comment.
100 is a magic number, create constant
| int number = random.nextInt(100) + 1; | ||
| return new Ball(color, number); | ||
| } | ||
|
|
| // create three balls using class Lottery and print information about them in console | ||
| Lottery lottery = new Lottery(); | ||
|
|
||
| for (int i = 0; i < 3; i++) { |
There was a problem hiding this comment.
3 is a magic number, create constant
| Ball ball = lottery.getRandomBall(); | ||
| System.out.println(ball); |
There was a problem hiding this comment.
| Ball ball = lottery.getRandomBall(); | |
| System.out.println(ball); | |
| System.out.println(lottery.getRandomBall()); |
No description provided.