improved the code

Author: YuliiaNisha

src/main/java/mate/academy/rickandmorty/Application.java

@@ -9,14 +9,14 @@
 @RequiredArgsConstructor
 @SpringBootApplication
 public class Application implements CommandLineRunner {
-    private final CharacterService charactersService;
+    private final CharacterService characterService;
 
     public static void main(String[] args) {
         SpringApplication.run(Application.class, args);
     }
 
     @Override
     public void run(String... args) throws Exception {
-        charactersService.fetchToDb();
+        characterService.fetchToDb();
     }
 }

src/main/java/mate/academy/rickandmorty/controller/CharacterController.java

@@ -13,6 +13,7 @@
 import mate.academy.rickandmorty.service.CharacterService;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 
 @Tag(name = "Rick and Morty characters API",
@@ -52,7 +53,7 @@ CharacterDto getRandomCharacter() {
     List<CharacterDto> search(
             @Parameter(description = "Search parameter, name or "
                     + "part of a name, to look for", example = "Alice")
-            CharacterSearchParameters searchParameters) {
+            @RequestParam CharacterSearchParameters searchParameters) {
         return characterService.search(searchParameters);
     }
 }

src/main/java/mate/academy/rickandmorty/repository/character/CharacterSpecificationProviderManager.java

@@ -19,7 +19,8 @@ public SpecificationProvider<Character> getSpecificationProvider(String key) {
                 .filter(p -> p.getKey().equals(key))
                 .findFirst()
                 .orElseThrow(
-                        () -> new RuntimeException("")
+                        () -> new RuntimeException("Can't provide specification "
+                        + "for key: " + key)
                 );
     }
 }

src/main/java/mate/academy/rickandmorty/service/CharacterServiceImpl.java

@@ -32,7 +32,7 @@ public void fetchToDb() {
 
     @Override
     public CharacterDto getRandomCharacter() {
-        long randomId = new Random().nextLong(characterRepository.count() + 1);
+        long randomId = new Random().nextInt((int) (characterRepository.count() + 1));
         Character randomCharacter =
                 characterRepository.findById(randomId)
                         .orElseThrow(

src/main/java/mate/academy/rickandmorty/service/RickAndMortyClient.java

@@ -46,7 +46,8 @@ private RickAndMortyResponseDataDto getResponseObject(HttpRequest httpRequest) {
                     getHttpResponse(httpRequest).body(),
                     RickAndMortyResponseDataDto.class);
         } catch (JsonProcessingException e) {
-            throw new ObjectMapperException("Failed to read httpResponse: ", e);
+            throw new ObjectMapperException("URL: " + httpRequest.uri()
+                    + " Failed to read httpResponse: ", e);
         }
     }
 
@@ -61,7 +62,9 @@ private HttpResponse<String> getHttpResponse(HttpRequest httpRequest) {
             }
             return response;
         } catch (IOException | InterruptedException e) {
-            throw new ApiException("Cannot get all characters from API: ", e);
+            throw new ApiException("URL: "
+                    + httpRequest.uri()
+                    + " Cannot get all characters from API: ", e);
         }
     }
 }