Implement Rick and Morty API #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliia-ponomarenko
approved these changes
Oct 3, 2024
Comment on lines
+10
to
+15
| @AllArgsConstructor | ||
| @Component | ||
| public class RickAndMortyService { | ||
| private static final String API_URL = "https://rickandmortyapi.com/api/character"; | ||
| private Client<RickAndMortyApiResponseDataDto> client; | ||
| private CharacterService characterService; |
There was a problem hiding this comment.
Suggested change
| @AllArgsConstructor | |
| @Component | |
| public class RickAndMortyService { | |
| private static final String API_URL = "https://rickandmortyapi.com/api/character"; | |
| private Client<RickAndMortyApiResponseDataDto> client; | |
| private CharacterService characterService; | |
| @RequiredArgsConstructor | |
| @Component | |
| public class RickAndMortyService { | |
| private static final String API_URL = "https://rickandmortyapi.com/api/character"; | |
| private final Client<RickAndMortyApiResponseDataDto> client; | |
| private final CharacterService characterService; |
| client.setUrl(dataFromApi.info().next()); | ||
| characterService.addListCharacter(dataFromApi.results()); | ||
| } | ||
| System.out.println("The database is successfully updated..."); |
There was a problem hiding this comment.
If you want to log something use Slf4j from Lombok instead of printing to console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.