Do Rick and Morty Task #197
Conversation
pom.xml
Outdated
| <artifactId>spring-boot-starter-data-jpa</artifactId> | ||
| </dependency> | ||
|
|
||
| <!-- For Web controllers --> |
There was a problem hiding this comment.
remove comments and commented code
There was a problem hiding this comment.
Okay! I specifically made comments for future projects because adding or incorrectly adding dependencies makes strange mistakes. It's easy to correctly add a dependency to a new project by looking at the training project. I'll save a copy to my local storage.
| @Service | ||
| @RequiredArgsConstructor | ||
| public class CharacterServiceImpl implements CharacterService { | ||
| private static final String RICK_AND_MORTY_API_URL = "https://rickandmortyapi.com/api/character"; |
There was a problem hiding this comment.
you can store this value in application proprties and get from it by using @Value
| } | ||
|
|
||
| @Override | ||
| public void syncCharactersFromExternalApi() { |
There was a problem hiding this comment.
it's better to replace this logic to CharacterClient service for example
There was a problem hiding this comment.
No problem . I wanted to emphasise for those watching the project that there is an initialisation phase. That's why I did it.
…ue to get the Api Url value from the application.properties file. Move the logic of getting the initial data to the CharacterInitializeClient service class.
No description provided.