jv-rick-and-morty - first attempt #229
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 Your code is well-structured and meets the core functionality needed. Just a few minor suggestions: consider updating the TOTAL_CHARS dynamically if possible, enhance error messages for better context, and replace the <PACKAGE_NAME>.impl placeholder with the actual package name. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| componentModel = "spring", | ||
| injectionStrategy = InjectionStrategy.CONSTRUCTOR, | ||
| nullValueCheckStrategy = NullValueCheckStrategy.ALWAYS, | ||
| implementationPackage = "<PACKAGE_NAME>.impl" |
There was a problem hiding this comment.
The placeholder <PACKAGE_NAME>.impl should be replaced with the actual package name where the mapper implementations will reside. Ensure to update this before using the configuration.
| } catch (IOException | InterruptedException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Consider adding a more descriptive error message when throwing the RuntimeException, to provide better context about the failure. For example, include information about the request or the specific operation that failed.
| @Service | ||
| @RequiredArgsConstructor | ||
| public class CharacterServiceImpl implements CharacterService { | ||
| private static final long TOTAL_CHARS = 826; |
There was a problem hiding this comment.
The TOTAL_CHARS constant assumes a fixed number of characters (826). Ensure this value is updated if the external data source changes, or consider dynamically determining the total number of characters if possible.
No description provided.