Skip to content

chore(dialog): change animation properties to methods #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(dialog): change animation properties to methods #5464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dialog/internal/dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ export class Dialog extends LitElement {
* Gets the opening animation for a dialog. Set to a new function to customize
* the animation.
*/
getOpenAnimation = () => DIALOG_DEFAULT_OPEN_ANIMATION;
getOpenAnimation() { return DIALOG_DEFAULT_OPEN_ANIMATION; }

/**
* Gets the closing animation for a dialog. Set to a new function to customize
* the animation.
*/
getCloseAnimation = () => DIALOG_DEFAULT_CLOSE_ANIMATION;
getCloseAnimation() { return DIALOG_DEFAULT_CLOSE_ANIMATION; }

private isOpen = false;
private isOpening = false;
Expand Down