Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #45
This PR adds the
optimake serve
command thatoptimade.jsonl
;optimade.jsonl
.Uses the
insert_from_jsonl
feature from the PR Materials-Consortia/optimade-python-tools#2094Couple of comments:
optimade-python-tools
server. I ended up just passing the config through environment variables.optimade-python-tools
instead, considering we're passing in the jsonl anyways.Note: I also changed the default
optimake
command tooptimake convert
.@ml-evs does this approach make sense? if you agree, i'll try to think how to add tests for this as well.