Try to defer aiida imports where not used #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/defer-aiida-import
branch
from
b3539af to
b690508
Compare
ml-evs
force-pushed
the
ml-evs/defer-aiida-import
branch
from
b690508 to
c66da3c
Compare
|
thanks @ml-evs , yes i fully approve this change. But mind checking and fixing the tests? feel free to merge after they are fixed. |
|
Had to do a bit of restructuring to get the tests to pass, so I'll let you review again before merging @eimrek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78 by wrapping imports in try/excepts and using deferred type hints where possible. I have not tested all the functionality yet, only simply running the
optimakeCLI with no arguments.Also run the tests with multiple Python versions