Skip to content

Feature/replace regex#10

Open
nastymorbol wants to merge 2 commits intomatheval:mainfrom
nastymorbol:feature/replace-regex
Open

Feature/replace regex#10
nastymorbol wants to merge 2 commits intomatheval:mainfrom
nastymorbol:feature/replace-regex

Conversation

@nastymorbol
Copy link
Copy Markdown

Replaced some Regex with constant expressions for performance improvement.

@s-michael-telford
Copy link
Copy Markdown

I considered making similar changes, but was going to recommend using the built it char static functions instead. Specifically, char.IsAsciiDigit or char.IsDigit, char.IsAsciiLetter or char.IsLetter etc.

@nastymorbol
Copy link
Copy Markdown
Author

Since the static char functions are unicode, i prefer to work with explicit ASCII characters. Unfortunately, I already had problems where my customers used some unicode characters using copy paste, which I then misinterpreted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants