Skip to content

Conversation

inetfuture
Copy link

I use this library with browserify, then generate the dist for others to use. One of them tried to load it with requirejs with shim config, it failed, because this library take over the whole module.

I'm not sure if my change is appropriate, just tell me if you think it's not, thanks.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.74%) to 91.85% when pulling f371dd6 on inetfuture:patch-1 into 792fdab on mathiasbynens:master.

@inetfuture
Copy link
Author

@mathiasbynens please look into this

@stackOverMind
Copy link

Thank you @inetfuture ,I have the same problem,I think your patch works for me

@mathiasbynens mathiasbynens force-pushed the master branch 4 times, most recently from 4eff386 to d4de352 Compare December 4, 2017 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants