Skip to content

Don't try to create the clearspeak menu if enrichment is disabled #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 2, 2025

This PR prevents the menu code from trying to create the clearspeak setting menu when enrichment is off (and so the webworker may not even be created yet). When enrichment is off, the speech menu is disabled, so the clearspeak menu will not be available in that case, so it is OK to not generate it.

@dpvc dpvc requested a review from zorkow July 2, 2025 14:43
@dpvc dpvc added this to the v4.0 milestone Jul 2, 2025
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (4d1e195) to head (3d27197).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1292   +/-   ##
========================================
  Coverage    86.71%   86.71%           
========================================
  Files          337      337           
  Lines        83979    83979           
  Branches      4750     4750           
========================================
  Hits         72826    72826           
  Misses       11130    11130           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant