Skip to content

Commit 6f067d5

Browse files
committed
doc(event cache): add a code comment indicating why room updates processing isn't happening concurrently
1 parent d6fe654 commit 6f067d5

File tree

1 file changed

+5
-0
lines changed
  • crates/matrix-sdk/src/event_cache

1 file changed

+5
-0
lines changed

crates/matrix-sdk/src/event_cache/mod.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,11 @@ impl EventCacheInner {
525525
self.multiple_room_updates_lock.lock().await
526526
};
527527

528+
// Note: bnjbvr tried to make this concurrent at some point, but it turned out
529+
// to be a performance regression, even for large sync updates. Lacking
530+
// time to investigate, this code remains sequential for now. See also
531+
// https://github.com/matrix-org/matrix-rust-sdk/pull/5426.
532+
528533
// Left rooms.
529534
for (room_id, left_room_update) in updates.left {
530535
let room = self.for_room(&room_id).await?;

0 commit comments

Comments
 (0)