feat(timeline): report progress for media uploads #5454
+278
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5454 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 334 334
Lines 92420 92433 +13
Branches 92420 92433 +13
=======================================
+ Hits 82196 82208 +12
- Misses 6378 6379 +1
Partials 3846 3846 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5454 will improve performances by 21.81%Comparing Summary
Benchmarks breakdown
|
Johennes
force-pushed
the
johannes/timeline-media-upload-progress
branch
from
abc8928 to
a01918f
Compare
…ate::NotSentYet Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
…ntYet Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
johannes/timeline-media-upload-progress
branch
from
8cf4c7d to
77966e5
Compare
…::NotSentYet Move AbstractProgress from client to timeline Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
…tSendState::NotSentYet Retain progress when applying remote echo Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
johannes/timeline-media-upload-progress
branch
from
3f36d7e to
c23d92d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to only contain the timeline changes broken out from #5008 (together with #5453 which this depends on).
Signed-off-by: