Fixed mass2_batch np.warnings not existing error, and moved mass2_gpu to its own file #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to use mass2_batch, it didn't work because np.warnings is not real (or is deprecated). I'm assuming the real warnings package was intended, so I changed it to that. I also changed n_jobs < 1 to default to n_jobs = 1 because using all available cpus when that possibly wasn't intended seems like a great way to promise failure. n_jobs = 1 will just be slow.
Additionally, I don't want the gpu version, and I'm tired of hearing about (or supressing the warning about) how I can't run it without cupy every time I import mass_ts. Thus, I moved it to its very own file, so everything is still there (including the warning) without bothering me when I'm trying to run something else.