Feature request: - (slurs)

[jrdndj]

This project has helped me so good so far. Im currently having trouble working on in-between measure slurs such as

D E F G/E/- | E F G A |

specifically looking at E/- | E

Lemme know if this feature will come soon or a way to address this. I looked at the assets and we dont have the sprite for this as well.

Thank you so much!

[matthewcpp]

Hello there, glad to hear this code is working for you. Admittedly I haven't touched it in quite a while.

I can take a look at what would go into adding support for ties & slurs, the parsing part seems straightforward. On the rendering side, I am wondering if using a sprite makes sense or maybe it would be better to use a line renderer to draw the tie. Do you have any thoughts on that?

[jrdndj]

I agree. I think it will be similar to the usual ties where you connect them with bars. since these ties just happen in between measures | then its always just adding a curved line at the bottom/head of the notes (so yeah more of the sprite than line renderer). Thanks for looking into it btw

…

On Thu, Feb 29, 2024 at 3:12 PM Matthew LaRocca ***@***.***> wrote: Hello there, glad to hear this code is working for you. Admittedly I haven't touched it in quite a while. I can take a look at what would go into adding support for ties & slurs, the parsing part seems straightforward. On the rendering side, I am wondering if using a sprite makes sense or maybe it would be better to use a line renderer to draw the tie. Do you have any thoughts on that? — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2KZ2NS3VIDGPYLHQMGPGTYV43NFAVCNFSM6AAAAABD4TVNWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRGIZDSMJWGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- DISCLAIMER AND CONFIDENTIALITY NOTICE The information contained in this e-mail, including those in its attachments, is confidential and intended only for the person(s) or entity(ies) to which it is addressed. If you are not an intended recipient, you must not read, copy, store, disclose, distribute this message, or act in reliance upon the information contained in it. If you received this e-mail in error, please contact the sender and delete the material from any computer or system. Any views expressed in this message are those of the individual sender and may not necessarily reflect the views of De La Salle University. 

[matthewcpp]

Was pretty busy over the weekend but I was able to get the basics in for supporting slurs...i plugged your example abc in and this is what its looking like:

Is that what you had in mind?

[jrdndj]

Oops, totally missed this. But this looks good to me! WIll you be updating this soon ?

…

On Mon, Mar 4, 2024 at 6:15 AM Matthew LaRocca ***@***.***> wrote: Was pretty busy over the weekend but I was able to get the basics in for supporting slurs...i plugged your example abc in and this is what its looking like: image.png (view on web) <https://github.com/matthewcpp/ABCUnity/assets/2367648/ba29398b-7087-43d6-92fa-c6b3cd85527b> Is that what you had in mind? — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2KZ2NKHKDSASZDWDQ6GFTYWP7PHAVCNFSM6AAAAABD4TVNWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVG42DQMJUHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- DISCLAIMER AND CONFIDENTIALITY NOTICE The information contained in this e-mail, including those in its attachments, is confidential and intended only for the person(s) or entity(ies) to which it is addressed. If you are not an intended recipient, you must not read, copy, store, disclose, distribute this message, or act in reliance upon the information contained in it. If you received this e-mail in error, please contact the sender and delete the material from any computer or system. Any views expressed in this message are those of the individual sender and may not necessarily reflect the views of De La Salle University. 

[matthewcpp]

Heya,

So i think the basic rendering is in place...but there is more work to be done for the feature to be totally complete.

• logic for placement to be made a bit more robust, especially in the case of nested slurs
• slurs and ties across multiple score lines are not currently implemented.

In any event, it might be in a good enough state for you to give it a shot. Can you grab the render-slurs-ties branch and see if it is working for your use case?

[jrdndj]

hello. thanks for this. Ive currently installed the master branch like how it was described. however i dunno how to do it with the latest branch you modified. would you be able to guide me how to do this?

ive made changes to the master version of the code as well (in my machine). when i tried to simply replace the files, i had so many exceptions xD

sorry for the stupid question but looking forward to your help