1.3.0 minor fixes #556
Merged
1.3.0 minor fixes #556
+199
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2025
Closed
Closed
Merged
Closed
Open
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
18 tasks
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
WalkthroughWrapped and restyled the logs search input, removed shadows from several button variants, and added OTEL conversion support for ResponsesRequest/ResponsesStreamRequest with a new helper that emits request params and response output messages into spans. Changes
Sequence Diagram(s)sequenceDiagram
participant Handler as Request handler
participant Converter as otel/converter
participant OTLP as OpenTelemetry
Note over Handler,Converter: Incoming ResponsesRequest / ResponsesStreamRequest
Handler->>Converter: createResourceSpan(req)
Converter->>Converter: getResponsesRequestParams(req)
Converter->>OTLP: Start span "gen_ai.responses" + params
Note over Converter,OTLP: Response produced
Converter->>Converter: completeResourceSpan(resp)
Converter->>Converter: Build gen_ai.responses.output_messages from resp.Output
Converter->>OTLP: Add output messages, usage, tokens, cost
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ui/app/logs/views/filters.tsx(1 hunks)ui/components/ui/button.tsx(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
ui/app/logs/views/filters.tsx (1)
ui/components/ui/input.tsx (1)
Input(15-69)
🔇 Additional comments (2)
ui/components/ui/button.tsx (1)
13-17: LGTM!The removal of
shadow-xsfrom button variants creates a cleaner, flatter design consistent with the border-focused styling updates elsewhere in the PR.ui/app/logs/views/filters.tsx (1)
101-102: LGTM!The bordered container wrapper and icon adjustments create a cohesive search component that aligns well with the overall styling updates.
akshaydeo
force-pushed
the
10-06-1.3.0_minor_fixes
branch
from
d277c42 to
d67ceba
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
plugins/otel/converter.go (1)
287-354: Fix formatting inconsistencies.The implementation looks correct overall, but there are minor formatting issues:
- Line 314: The line is under-indented. It should align with the opening
ifstatement.- Line 331: Double space before
&&operator.Apply this diff to fix the formatting:
if req.Params.Text != nil { if req.Params.Text.Verbosity != nil { - params = append(params, kvStr("gen_ai.request.text", *req.Params.Text.Verbosity)) + params = append(params, kvStr("gen_ai.request.text", *req.Params.Text.Verbosity)) } if req.Params.Text.Format != nil { params = append(params, kvStr("gen_ai.request.text_format_type", req.Params.Text.Format.Type)) } } if req.Params.TopLogProbs != nil { params = append(params, kvInt("gen_ai.request.top_logprobs", int64(*req.Params.TopLogProbs))) } if req.Params.TopP != nil { params = append(params, kvDbl("gen_ai.request.top_p", *req.Params.TopP)) } if req.Params.ToolChoice != nil { if req.Params.ToolChoice.ResponsesToolChoiceStr != nil && *req.Params.ToolChoice.ResponsesToolChoiceStr != "" { params = append(params, kvStr("gen_ai.request.tool_choice_type", *req.Params.ToolChoice.ResponsesToolChoiceStr)) } - if req.Params.ToolChoice.ResponsesToolChoiceStruct != nil && req.Params.ToolChoice.ResponsesToolChoiceStruct.Name != nil { + if req.Params.ToolChoice.ResponsesToolChoiceStruct != nil && req.Params.ToolChoice.ResponsesToolChoiceStruct.Name != nil { params = append(params, kvStr("gen_ai.request.tool_choice_name", *req.Params.ToolChoice.ResponsesToolChoiceStruct.Name)) } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
plugins/otel/converter.go(4 hunks)ui/app/logs/views/filters.tsx(1 hunks)ui/components/ui/button.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- ui/components/ui/button.tsx
- ui/app/logs/views/filters.tsx
🧰 Additional context used
🧬 Code graph analysis (1)
plugins/otel/converter.go (3)
core/schemas/bifrost.go (1)
BifrostResponsesRequest(136-142)plugins/otel/types.go (2)
KeyValue(21-21)AnyValue(24-24)core/schemas/responses.go (2)
ResponsesToolChoiceStruct(1150-1156)ResponsesResponse(85-98)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
🔇 Additional comments (4)
plugins/otel/converter.go (4)
380-382: LGTM!The handling of ResponsesRequest and ResponsesStreamRequest is consistent with other request types in the switch statement.
420-420: LGTM!Good formatting cleanup to maintain consistency with other token usage lines.
493-505: LGTM!The response object handling is correctly implemented with appropriate nil checks and follows the same pattern as other object types.
287-354: No duplicate implementation found. The functiongetResponsesRequestParamsis defined only once in plugins/otel/converter.go; the duplicate claim is inaccurate.Likely an incorrect or invalid review comment.
akshaydeo
force-pushed
the
10-06-1.3.0_minor_fixes
branch
from
d67ceba to
679f43d
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
plugins/otel/converter.go(5 hunks)ui/app/logs/views/filters.tsx(1 hunks)ui/components/ui/button.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- ui/components/ui/button.tsx
- ui/app/logs/views/filters.tsx
🧰 Additional context used
🧬 Code graph analysis (1)
plugins/otel/converter.go (4)
core/schemas/bifrost.go (1)
BifrostResponsesRequest(136-142)plugins/otel/types.go (2)
KeyValue(21-21)AnyValue(24-24)core/schemas/providers/gemini/types.go (3)
Type(778-778)Role(12-12)Content(955-963)core/schemas/responses.go (4)
ResponsesToolChoiceStruct(1150-1156)ResponsesExtendedResponseUsage(125-130)ResponsesResponse(85-98)ResponsesReasoning(928-931)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
akshaydeo
force-pushed
the
10-06-1.3.0_minor_fixes
branch
3 times, most recently
from
907d7eb to
ae2fbc2
Compare
18 tasks
akshaydeo
force-pushed
the
10-06-1.3.0_minor_fixes
branch
from
ae2fbc2 to
dfbd502
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added OpenTelemetry support for the Responses API and improved UI styling for the logs search input and buttons.
Changes
getResponsesRequestParamsfunction to handle responses request parametersType of change
Affected areas
How to test
Verify the updated UI components render correctly and test the OpenTelemetry tracing for Responses API:
Navigate to the logs page to check the search input styling and verify button appearances throughout the application.
Screenshots/Recordings
[Add before/after screenshots of the updated search input and buttons]
Breaking changes
Related issues
N/A
Security considerations
No security implications.
Checklist
docs/contributing/README.mdand followed the guidelines