hello! live your driver! #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very well written driver my hat is off to you good sir! Some of these changes u mmay not want or at least could use compile time options IE if the spi bus can sleep, tho ii have noticed a trend of kernel commits converting spi drivers over so maybethats a preferred thing these days i dunno. nothing major here just sum fixes for updated kernels and misc stuff. I dont have a tx unit and rx unit they all do both so the default setup maybe confusing or bad for sum people. Now works great with my ftdi usb mpsse spi driver! This pull request was done more so i ccould thank and compliment you on your excellant code, thank you my friend!