-
Notifications
You must be signed in to change notification settings - Fork 23k
setTimeout() on Window/Worker plus consistency fixes #42072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hamishwillee
wants to merge
4
commits into
mdn:main
Choose a base branch
from
hamishwillee:tt_setTimeout_n_fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Contributor
Preview URLs (7 pages)
External URLs (3)URL:
URL:
(comment last updated: 2025-12-02 05:53:18) |
Josh-Cena
reviewed
Nov 24, 2025
hamishwillee
commented
Nov 24, 2025
hamishwillee
commented
Nov 24, 2025
Collaborator
Author
|
@pepelsbey Can you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Content:Firefox
Content in the Mozilla/Firefox subtree
Content:WebAPI
Web API docs
size/m
[PR only] 51-500 LoC changed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
Window.setTimeout()andWorkerGlobalScope.setTimeout()for trusted types, following the same approach as #42042This also did some consistency fixes across both this and the
setIntervalmethods so that they have the same name for the function param (func) and the arguments are referred to asparamrather thanargs- which is consistent with the template for web apis.There were a few layout change and improvements to the docs - these map the similar changes done previously for
setInterval()This is part of project being tracked in #41507